Enabling support for process decompositions with empty pencils.#102
Closed
romerojosh wants to merge 2 commits intomainfrom
Closed
Enabling support for process decompositions with empty pencils.#102romerojosh wants to merge 2 commits intomainfrom
romerojosh wants to merge 2 commits intomainfrom
Conversation
Signed-off-by: Josh Romero <joshr@nvidia.com>
Signed-off-by: Josh Romero <joshr@nvidia.com>
Collaborator
Author
|
Going to close this on in favor of #103. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #101.
As it stands right now, cuDecomp will not allow users to create grid descriptors that potentially result in situations where processes have empty pencils with zero elements in any pencil orientation (i.e. x-pencils, y-pencils, z-pencils), which is very conservative. Users might desire using cuDecomp on only a subset of the pencil orientations and might not care if the other orientations have empty processes. For example, in #101, that user is interested in using halo-exchange routines on z-pencils with
N x N x 1dimensions. The current empty pencil checks will not allow this usage at all due to thex-andy-pencil orientations attempting to distribute the1dimension.This PR addresses this limitation by:
Transpose APIs will work in these scenarios as expected.
Halo exchange APIs will throw an error if the halo exchange is along a dimension with an empty pencil as what the halo exchange operation should do in this configuration isn't very well defined.
An alternative option to (3) is to just have cuDecomp throw an error whenever it detects communication involving dimensions with empty pencils. This would still allow use cases like #101, but with reduced complexity introduced from the introduction of empty pencil handling. This may be the preferred solution but not sure at the moment.